Skip to content

[CMake] [MLIR] [Backport] Backport cmake from upstream to add missing mlir-headers dependencies #1928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[CMake] [MLIR] [Backport] Backport cmake from upstream to add missing mlir-headers dependencies #1928

wants to merge 1 commit into from
+9 −3

Conversation

badumbatish
Copy link
Contributor

Similar to #1927 , this allows generation of the missing mlir tablegen targets without going through

$(ninja -C build_pilot -t targets all | grep IncGen | sed 's/:.*//')

Helpful to #1917

@badumbatish badumbatish changed the title [MLIR] [Backport] Backport cmake from upstream to add missing mlir-headers dependencies [CMake] [MLIR] [Backport] Backport cmake from upstream to add missing mlir-headers dependencies Sep 30, 2025
@badumbatish
Copy link
Contributor Author

hmm not quite sure why its failing flang test cases due to error: unknown argument: '-emit-mlir'

@bcardosolopes bcardosolopes mentioned this pull request Sep 30, 2025
Merged
@badumbatish
Copy link
Contributor Author

hmm not quite sure why its failing flang test cases due to error: unknown argument: '-emit-mlir'

it seems this is a problem from upstream, I run the build command on check-flang against HEAD~1 and it fails with the same error msg

@bcardosolopes
Copy link
Member

bcardosolopes commented Oct 3, 2025 •
edited
Loading

it seems this is a problem from upstream, I run the build command on check-flang against HEAD~1 and it fails with the same error msg

We don't run check-flang in this CI (we're supposed to only run check-clang-cir) - see previous green jobs and look at the output - so maybe some of the cmake changes here are triggering dependencies it shouldn't?

@badumbatish
Copy link
Contributor Author

hmm i think flang depends on mlir, which explains why the flang cicd is triggered. I dont think i have any fixes for this, given that the commit for this in upstream is working. I can try to trace down via git bisect in the incubator but i'm not sure if its fruitful

@bcardosolopes
Copy link
Member

I can try to trace down via git bisect in the incubator but i'm not sure if its fruitful

Probably not worth it. Can you XFAIL the bad tests so we can get CI green? They will be resolved back when another rebase is done!

bcardosolopes
bcardosolopes approved these changes Oct 6, 2025
View reviewed changes
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once unrelated failing tests are XFAILed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcardosolopes bcardosolopes bcardosolopes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@badumbatish @bcardosolopes